This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Harden use of geth #15029
Merged
Harden use of geth #15029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mrose17
commented
Aug 15, 2018
mrose17
commented
- catch “unlikely” but possible errors
- handle SIGHUP an dSIGINT
- catch “unlikely” but possible errors - handle SIGHUP an dSIGINT
ryanml
reviewed
Aug 15, 2018
| @@ -104,29 +106,34 @@ const spawnGeth = async () => { | |||
| } | |||
|
|
|||
| const gethOptions = { | |||
| stdio: process.env.GETH_LOG ? 'inherit' : 'ignore' | |||
| stdio: ((envNet === 'ropsten') || process.env.GETH_LOG) ? 'inherit' : 'ignore' | |||
There was a problem hiding this comment.
is this included intentionally? i think that would should let GETH_LOG be the sole deciding indicator for logging, lest there is value in always having debug output on ropsten
There was a problem hiding this comment.
yes. it's intentional: if someone is on the test network, or someone turns on GETH_LOG, then we get logs, otherwise not. in other words, for production use, no logs by default; for testnet use, logs by default.
ryanml
reviewed
Aug 15, 2018
| process.on('exit', cleanupGeth) | ||
| process.on('SIGHUP', cleanupGethAndExit) | ||
| process.on('SIGTERM', cleanupGethAndExit) | ||
| process.on('SIGINT', cleanupGethAndExit) |
ryanml
approved these changes
Aug 15, 2018
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.